feat: improve artwork lists performance (attempt 1) #8782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimatretyak
changed the title
dimatretyak
changed the title
dimatretyak
commented
May 30, 2023
| </Join> | ||
| </Flex> | ||
| </TouchableOpacity> | ||
| ) | ||
| } | ||
|
|
||
| export const ArtworkListItem = memo(Item) |
There was a problem hiding this comment.
re-render the component only when the props have changed
dimatretyak
changed the title
anandaroop
previously approved these changes
May 30, 2023
| @@ -12,9 +13,13 @@ interface ArtworkListsProps { | |||
| me: ArtworkLists_me$key | null | |||
| } | |||
|
|
|||
| type ArtworkList = | |||
| | NonNullable<ArtworkLists_me$data["savedArtworksArtworkList"]> | |||
| | ExtractNodeType<ArtworkLists_me$data["savedArtworksArtworkList"]> | |||
There was a problem hiding this comment.
I'm unclear about what this type is representing. Is L18 L17 not sufficient?
(The ExtractNodeType utility seems to be meant for use with collections only?)
There was a problem hiding this comment.
Is L18 not sufficient
it will be enough, but it seems to me it would be more correct to use the type of "Saved Artworks" and Custom Artwork lists
my bad, i forgot to update some code
There was a problem hiding this comment.
The ExtractNodeType utility seems to be meant for use with collections only
yes, for cases when the query has edges -> node. For example
{
someConnection {
edges {
node {
...
}
}
}
}There was a problem hiding this comment.
Done: c7f2a0d
dimatretyak
deleted the
dimatretyak/feat/improve-artwork-lists-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Notion Card: https://www.notion.so/artsy/Selecting-unselecting-lists-in-the-sheet-can-feel-a-bit-sluggish-Takes-a-second-or-two-to-settle-b63ab6d694dc4f8e94ccefda22386b84
Description
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.