fix: use the same relay env between Home screen and useMutation
#8636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gkartalis thank you 🙏 |
gkartalis
reviewed
May 5, 2023
src/app/Scenes/Home/Home.tests.tsx
Outdated
Comment on lines
23
to
27
| let mockEnvironment: ReturnType<typeof createMockEnvironment> | ||
|
|
||
| beforeEach(() => { | ||
| mockEnvironment = createMockEnvironment() | ||
| }) |
There was a problem hiding this comment.
Here we could also use 'getRelayMockEnvironment' theoretically, no need to refactor though
There was a problem hiding this comment.
I'm doing it right now. I noticed getRelayMockEnvironment at the last moment
There was a problem hiding this comment.
When using getRelayMockEnvironment I get an error. I'll try to understand the reason
There was a problem hiding this comment.
This will work if we manually pass mocked env to the Home query renderer component: 1ee7eb8
olerichter00
previously approved these changes
May 8, 2023
dimatretyak
added
Squash On Green
dimatretyak
force-pushed
the
dimatretyak/fix/home-screen-refetch-data
branch
from
ac0bab7
to
adbde24
Compare
dimatretyak
added
the
Squash On Green
This was referenced May 9, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves CX-3586
Related PR: #8442
Description
The problem in the CX-3586 task was that we used different relay env on the Home screen and
useMutation(this hook uses env, which is passed here).We have already faced such a problem here and here + some related PR from George
Demo
Artists
Artists.mp4
artists.mp4
Artworks
Artworks.mp4
artworks.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
useMutation- dimatretyakNeed help with something? Have a look at our docs, or get in touch with us.