Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FX-4759): Display toast with actions summary for artwork lists flow #8607

Merged
merged 8 commits into from
May 4, 2023

Conversation

dimatretyak
Copy link
Contributor

@dimatretyak dimatretyak commented May 2, 2023

This PR resolves FX-4759

Demo

Added to the single artwork list

demo-1.mp4

Added to multiple artwork lists

demo-2.mp4

Removed from the single artwork list

demo-3.mp4

Removed from multiple artwork lists

demo-4.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Display toast with actions summary for artwork lists flow - dimatretyak

Need help with something? Have a look at our docs, or get in touch with us.

@dimatretyak dimatretyak self-assigned this May 2, 2023
@dimatretyak dimatretyak marked this pull request as ready for review May 3, 2023 13:52
ArtworkListState,
ResultAction,
SaveResult,
} from "./types"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dimatretyak dimatretyak merged commit 2e66b3d into main May 4, 2023
@dimatretyak dimatretyak deleted the dimatretyak/feat/artwork-lists-toast-summary branch May 4, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants