-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MOPLAT-619): Context menu for artwork items #8606
Conversation
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ContextMenuTouchable/ContextMenuTouchable.tsx
Outdated
Show resolved
Hide resolved
807e67e
to
1dad7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @gkartalis, thanks for working through all of those comments! If there aren't any more big changes incoming feel free to merge when you feel it's ready 👍 🤙
Thanks for the insightful comments @damassi! The only issue that is left with this are some warnings coming from the relay store like this:
Not sure if we should merge with this or not 🤷♂️. Will spent ~15 minutes in trying to solve them and will update |
reading this which looks relevant |
oh yeah, lets fix this before merge. Seen that come up here and there, but not too sure. |
8097fe0
to
a932e00
Compare
…de (#8637) * refactor(context): move create alert and contain context * chore(context): decouple context and touchable
This PR resolves MOPLAT-619
Description
Demo
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-22.at.16.58.13.mp4
TODO:
Warning: RelayResponseNormalizer: Invalid record. The record contains two instances of the same id: `QXJ0d29yazo2NDM4NzhlYWE0NzBhMzAwMGM3YzRmMGM=` with conflicting field, widthCm and its values: 132 and null. If two fields are different but share the same id, one field will overwrite the other.
not sure how it affects the app, better to solve it before merging
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.