Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MOPLAT-619): Context menu for artwork items #8606

Merged
merged 28 commits into from
May 22, 2023
Merged

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented May 2, 2023

This PR resolves MOPLAT-619

Description

  • Adds context menu on ArtworkGridItem and ArtworkRailCard
    • user is able to create alert
    • user is able to like / dislike the artwork
    • user is able to view artwork in room
  • Behind a FF and enabled only on iOS (for now)
  • refactored some tests that were type complaining

Demo

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-22.at.16.58.13.mp4

TODO:

  1. ✅ (Done) there seems to be something that relay doesn't like:
Warning: RelayResponseNormalizer: Invalid record. The record contains two instances of the same id: 
`QXJ0d29yazo2NDM4NzhlYWE0NzBhMzAwMGM3YzRmMGM=` with conflicting field, widthCm and its values: 132 and 
null. If two fields are different but share the same id, one field will overwrite the other.

not sure how it affects the app, better to solve it before merging

  1. ✅ (Done) Will refactor the ArtworkGridItem.tests.tsx since they are not properly written and all of them break.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

  • Context menu for artwork items - gkartalis

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis self-assigned this May 2, 2023
damassi
damassi previously approved these changes May 4, 2023
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @gkartalis, thanks for working through all of those comments! If there aren't any more big changes incoming feel free to merge when you feel it's ready 👍 🤙

@gkartalis
Copy link
Member Author

Thanks for the insightful comments @damassi!

The only issue that is left with this are some warnings coming from the relay store like this:

Warning: RelayResponseNormalizer: Invalid record. The record contains two instances of the same id: 
`QXJ0d29yazo2NDM4NzhlYWE0NzBhMzAwMGM3YzRmMGM=` with conflicting field, widthCm and its values: 132 and 
null. If two fields are different but share the same id, one field will overwrite the other.

Not sure if we should merge with this or not 🤷‍♂️. Will spent ~15 minutes in trying to solve them and will update

@gkartalis
Copy link
Member Author

reading this which looks relevant

@damassi
Copy link
Member

damassi commented May 4, 2023

oh yeah, lets fix this before merge. Seen that come up here and there, but not too sure.

damassi
damassi previously approved these changes May 4, 2023
@gkartalis gkartalis marked this pull request as ready for review May 5, 2023 08:43
…de (#8637)

* refactor(context): move create alert and contain context

* chore(context): decouple context and touchable
@gkartalis gkartalis requested a review from damassi May 22, 2023 13:20
brainbicycle
brainbicycle previously approved these changes May 22, 2023
@gkartalis gkartalis merged commit 0ba7147 into main May 22, 2023
@gkartalis gkartalis deleted the gkartalis/MOPLAT-619 branch May 22, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants