feat: enable hermes on android #8577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
force-pushed
the
gkartalis/hermes-again
branch
from
05d4732
to
07ffc6b
Compare
gkartalis
commented
Apr 27, 2023
gkartalis
force-pushed
the
gkartalis/hermes-again
branch
from
ed6ca79
to
49c64e6
Compare
gkartalis
force-pushed
the
gkartalis/hermes-again
branch
from
49c64e6
to
94e241a
Compare
|
exciting! Seems like updating hermes-engine to version 10 fixes the issue! 🥇 found here a "mapping" of rn-versions and hermes-engine versions |
gkartalis
force-pushed
the
gkartalis/hermes-again
branch
from
94e241a
to
4dd46d8
Compare
MounirDhahri
approved these changes
May 5, 2023
| @@ -125,6 +119,14 @@ def jscFlavor = 'org.webkit:android-jsc-intl:+' | |||
| * on project.ext.react, JavaScript will not be compiled to Hermes Bytecode | |||
| * and the benefits of using Hermes will therefore be sharply reduced. | |||
| */ | |||
|
|
|||
| // order matters here, this must be set before the react.gradle apply | |||
There was a problem hiding this comment.
praise: was going to mention that, thanks for the note
|
@MounirDhahri Almost there, trying to figure out if |
8 tasks
|
Closing this due to #8658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves MOPLAT-732
Description
Re-enables hermes on android to investigate https://artsyproduct.atlassian.net/browse/MOPLAT-732
Turns out updating hermes-engine to version 0.10.0 fixes the issue that we were having, we def need to further QA it but so far it looks good!
Found the mapping of react-native versions to hermes versions here
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.