Skip to content

Commit

Permalink
fix: long input placeholders on Android (#10186)
Browse files Browse the repository at this point in the history
* fix: search input placeholder on android

* fix: long input placeholders on android
  • Loading branch information
MounirDhahri authored and araujobarret committed May 2, 2024
1 parent 22ff5e6 commit 9395627
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 5 deletions.
6 changes: 5 additions & 1 deletion src/app/Components/Bidding/Screens/BillingAddress.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ export const BillingAddress: React.FC<BillingAddressProps> = ({
ref={addressLine2Ref}
title="Address line 2"
optional
placeholder="Add your apt, floor, suite, etc."
placeholder={[
"Add your apt, floor, suite, etc.",
"Add your apt, floor, etc.",
"Add your apt, etc.",
]}
textContentType="streetAddressLine2"
returnKeyType="next"
enableClearButton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const MyCollectionSearchBar: React.FC<MyCollectionSearchBarProps> = ({
<Flex flexDirection="row" alignItems="center">
<Input
testID="MyCollectionSearchBarInput"
placeholder="Search by Artist, Artwork or Keyword"
placeholder={["Search by Artist, Artwork or Keyword", "Search by keyword", "Search"]}
onChangeText={setValue}
onFocus={onFocus}
onBlur={() => {
Expand Down
6 changes: 5 additions & 1 deletion src/app/Scenes/MyProfile/MyProfilePaymentNewCreditCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,11 @@ export const MyProfilePaymentNewCreditCard: React.FC<{}> = ({}) => {
ref={addressLine2Ref}
title="Address line 2"
optional
placeholder="Add apt, floor, suite, etc."
placeholder={[
"Add your apt, floor, suite, etc.",
"Add your apt, floor, etc.",
"Add your apt, etc.",
]}
onChangeText={actions.fields.addressLine2.setValue}
returnKeyType="next"
onSubmitEditing={() => cityRef.current?.focus()}
Expand Down
7 changes: 6 additions & 1 deletion src/app/Scenes/Search/Search.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ import { SEARCH_PILLS, SEARCH_THROTTLE_INTERVAL, TOP_PILL } from "./constants"
import { getContextModuleByPillName } from "./helpers"
import { PillType } from "./types"

const SEARCH_INPUT_PLACEHOLDER = "Search artists, artworks, galleries, etc"
const SEARCH_INPUT_PLACEHOLDER = [
"Search artists, artworks, galleries, etc",
"Search artists, artworks, etc",
"Search artworks, etc",
"Search",
]

export const searchQueryDefaultVariables: SearchQuery$variables = {
term: "",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ export const ArtworkDetailsForm: React.FC = () => {
<StandardSpace />
<Input
title="Materials"
placeholder="Oil on canvas, mixed media, lithograph.."
placeholder={[
"Oil on canvas, mixed media, lithograph, etc.",
"Oil on canvas, mixed media, etc.",
"Oil on canvas, etc.",
]}
testID="Submission_MaterialsInput"
value={values.medium}
onChangeText={(e) => setFieldValue("medium", e)}
Expand Down

0 comments on commit 9395627

Please sign in to comment.