fix: fetch unleash toggles/variants after user has logged in (#11339)

* fix: fetch unleash toggles/variants after user has logged in * fix: start unleash client each time user logs in
artsy · Jan 6, 2025 · 4529b08 · 4529b08
1 parent 16bbd91
commit 4529b08
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/app/store/AuthModel.ts b/src/app/store/AuthModel.ts
@@ -1,6 +1,7 @@
 import { ActionType, AuthService, CreatedAccount, ResetYourPassword } from "@artsy/cohesion"
 import Braze from "@braze/react-native-sdk"
 import { appleAuth } from "@invertase/react-native-apple-authentication"
+import AsyncStorage from "@react-native-async-storage/async-storage"
 import CookieManager from "@react-native-cookies/cookies"
 import { GoogleSignin, statusCodes } from "@react-native-google-signin/google-signin"
 import * as Sentry from "@sentry/react-native"
@@ -1012,6 +1013,7 @@ export const getAuthModel = (): AuthModel => ({
       __DEV__ && (await clearNavState()),
       await signOutGoogle(),
       LoginManager.logOut(),
+      await AsyncStorage.clear(),
       CookieManager.clearAll(),
       _globalCacheRef?.clear(),
     ])

diff --git a/src/app/utils/experiments/UnleashProvider.tsx b/src/app/utils/experiments/UnleashProvider.tsx
@@ -19,9 +19,12 @@ export function UnleashProvider({ children }: { children?: React.ReactNode }) {
   const { unleashEnv } = useUnleashEnvironment()
 
   useEffect(() => {
-    if (isHydrated) {
+    if (isHydrated && userId) {
       const client = getUnleashClient({ env: unleashEnv, userId })
 
+      // starts unleash client each time user logs in
+      client.start()
+
       client.on("initialized", () => {
         if (__DEV__) {
           console.log("Unleash initialized")
@@ -51,7 +54,7 @@ export function UnleashProvider({ children }: { children?: React.ReactNode }) {
         client.stop()
       }
     }
-  }, [unleashEnv, isHydrated])
+  }, [unleashEnv, isHydrated, userId])
 
   const onForeground = useCallback(() => {
     forceFetchToggles(unleashEnv)

diff --git a/src/app/utils/experiments/unleashClient.ts b/src/app/utils/experiments/unleashClient.ts
@@ -38,7 +38,6 @@ export function getUnleashClient(props?: {
       envBeingUsed = props?.env
     }
     unleashClient = createUnleashClient(nullToUndef(props?.userId))
-    unleashClient.start()
   }
   return unleashClient
 }