fix(lotsByFollowedArtists): make rail more defensive (#8833)

artsy · Jun 9, 2023 · 149b697 · 149b697
1 parent cb5ba50
commit 149b697
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 18 deletions.
diff --git a/src/app/Components/LotsByArtistsYouFollowRail/LotsByFollowedArtistsRail.tsx b/src/app/Components/LotsByArtistsYouFollowRail/LotsByFollowedArtistsRail.tsx
@@ -35,9 +35,9 @@ export const LotsByFollowedArtistsRail: React.FC<Props> = ({
 
   const { navigateToPageableRoute } = useNavigateToPageableRoute({ items: artworks })
 
-  const hasArtworks = artworks?.length
+  const hasSaleArtworks = artworks?.some((artwork) => artwork?.saleArtwork)
 
-  if (!hasArtworks) {
+  if (!hasSaleArtworks) {
     return null
   }
 
@@ -82,19 +82,25 @@ export const LotsByFollowedArtistsRail: React.FC<Props> = ({
         data={artworks}
         initialNumToRender={isTablet ? 10 : 5}
         windowSize={3}
-        renderItem={({ item: artwork }) => (
-          <SaleArtworkTileRailCardContainer
-            onPress={() => {
-              navigateToPageableRoute(artwork.href!)
-            }}
-            saleArtwork={artwork.saleArtwork!}
-            useSquareAspectRatio
-            useCustomSaleMessage
-            contextScreenOwnerType={OwnerType.sale}
-            cardSize={cardSize}
-            refreshRail={doRefresh}
-          />
-        )}
+        renderItem={({ item: artwork }) => {
+          if (!artwork?.saleArtwork) {
+            return null
+          }
+
+          return (
+            <SaleArtworkTileRailCardContainer
+              onPress={() => {
+                navigateToPageableRoute(artwork.href!)
+              }}
+              saleArtwork={artwork.saleArtwork!}
+              useSquareAspectRatio
+              useCustomSaleMessage
+              contextScreenOwnerType={OwnerType.sale}
+              cardSize={cardSize}
+              refreshRail={doRefresh}
+            />
+          )
+        }}
         keyExtractor={(item) => item.id}
         onScroll={isCloseToEdge(fetchNextPage)}
       />

diff --git a/src/app/Components/SaleArtworkTileRailCard/SaleArtworkTileRailCard.tsx b/src/app/Components/SaleArtworkTileRailCard/SaleArtworkTileRailCard.tsx
@@ -48,9 +48,9 @@ export const SaleArtworkTileRailCard: React.FC<SaleArtworkTileRailCardProps> = (
     useFeatureFlag("AREnableNewAuctionsRailCard") && cardSize === "large"
   const color = useColor()
   const tracking = useTracking()
-  const artwork = saleArtwork.artwork!
-  const extendedBiddingEndAt = saleArtwork.extendedBiddingEndAt
-  const lotEndAt = saleArtwork.endAt
+  const artwork = saleArtwork?.artwork!
+  const extendedBiddingEndAt = saleArtwork?.extendedBiddingEndAt
+  const lotEndAt = saleArtwork?.endAt
   const endAt = extendedBiddingEndAt ?? lotEndAt ?? saleArtwork.sale?.endAt ?? ""
   const startAt = saleArtwork.sale?.liveStartAt ?? saleArtwork.sale?.startAt ?? ""