Merge pull request #121 from articulate/style/perfsprint

style(lint): address perfsprint issues

.golangci.yml

@@ -25,7 +25,7 @@ issues:
   exclude-rules:
     - path: _test\.go
       linters:
-        - goerr113
+        - err113
 
 linters-settings:
   gocyclo:

internal/provider/provider.go

@@ -23,7 +23,7 @@ func init() {
 			desc += fmt.Sprintf(" Defaults to `%v`.", s.Default)
 		}
 		if s.Deprecated != "" {
-			desc += fmt.Sprintf(" __Deprecated__: %s", s.Deprecated)
+			desc += " __Deprecated__: " + s.Deprecated
 		}
 		return strings.TrimSpace(desc)
 	}

internal/provider/resource_site_test.go

@@ -24,9 +24,9 @@ func init() {
 
 func TestAccOhdearSite(t *testing.T) {
 	name := acctest.RandomWithPrefix("tf-acc-test")
-	url := fmt.Sprintf("https://example.com/%s", name)
-	resourceName := fmt.Sprintf("ohdear_site.%s", name)
-	updatedURL := fmt.Sprintf("%s/new", url)
+	url := "https://example.com/" + name
+	resourceName := "ohdear_site." + name
+	updatedURL := url + "/new"
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
@@ -74,8 +74,8 @@ func TestAccOhdearSite(t *testing.T) {
 
 func TestAccOhdearSite_EnableDisableChecks(t *testing.T) {
 	name := acctest.RandomWithPrefix("tf-acc-test")
-	url := fmt.Sprintf("https://example.com/%s", name)
-	resourceName := fmt.Sprintf("ohdear_site.%s", name)
+	url := "https://example.com/" + name
+	resourceName := "ohdear_site." + name
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
@@ -125,8 +125,8 @@ func TestAccOhdearSite_EnableDisableChecks(t *testing.T) {
 
 func TestAccOhdearSite_TeamID(t *testing.T) {
 	name := acctest.RandomWithPrefix("tf-acc-test")
-	url := fmt.Sprintf("https://example.com/%s", name)
-	resourceName := fmt.Sprintf("ohdear_site.%s", name)
+	url := "https://example.com/" + name
+	resourceName := "ohdear_site." + name
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
@@ -156,8 +156,8 @@ func TestAccOhdearSite_TeamID(t *testing.T) {
 
 func TestAccOhdearSite_HTTPDefaults(t *testing.T) {
 	name := acctest.RandomWithPrefix("tf-acc-test")
-	url := fmt.Sprintf("http://example.com/%s", name)
-	resourceName := fmt.Sprintf("ohdear_site.%s", name)
+	url := "http://example.com/" + name
+	resourceName := "ohdear_site." + name
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },