Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Commit

Permalink
Merge pull request #441 from articulate/feature/node-20
Browse files Browse the repository at this point in the history
build: upgrade to Node 20
  • Loading branch information
mloberg authored Sep 29, 2023
2 parents ae700b8 + 129a7c9 commit 2cb1690
Show file tree
Hide file tree
Showing 11 changed files with 6,354 additions and 5,132 deletions.
8 changes: 7 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ updates:
directory: /
schedule:
interval: monthly
groups:
actions:
patterns:
- "*"
- package-ecosystem: npm
directory: /
open-pull-requests-limit: 25
schedule:
interval: monthly
groups:
dev:
dependency-type: development
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ jobs:
with:
detail: invalid
- name: Check invalid JSON
run: 'test "${{ steps.json.outputs.error }}" == "detail is not valid JSON. SyntaxError: Unexpected token i in JSON at position 0"'
run: |
test "${{ contains(steps.json.outputs.error, 'detail is not valid json') }}" == "true"
- name: Test missing inputs
id: inputs
continue-on-error: true
Expand Down
1 change: 0 additions & 1 deletion .tool-versions

This file was deleted.

30 changes: 19 additions & 11 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ Here are some guidelines when contributing to aws-eventbridge-action.

## Setup

This action uses the `node16` runtime, so make sure you have Node.js 16 installed.
This action uses the `node20` runtime, so make sure you have Node.js 20 installed.
We use [act](https://github.com/nektos/act) to test the action locally. As of this
writing, the latest release does not support the `node16` runtime, so you'll need
writing, the latest release does not support the `node20` runtime, so you'll need
to install the latest unreleased version, which requires Go. `go install github.com/nektos/act@master`

## Testing
Expand Down Expand Up @@ -45,12 +45,16 @@ will need to create a release for the version.

We use [semantic versioning](https://semver.org/) for our releases.

You can also manually determine the next release by viewing the most recent [release](https://github.com/articulate/aws-eventbridge-action/releases). Your version will be similar in format to `v1.0.2` (PATCH) or `v1.1.0` (MINOR)
You can also manually determine the next release by viewing the most recent
[release](https://github.com/articulate/aws-eventbridge-action/releases). Your
version will be similar in format to `v1.0.2` (PATCH) or `v1.1.0` (MINOR)

### Releasing

* From the [release](https://github.com/articulate/aws-eventbridge-action/releases) page, Click `Draft a new release`
* Click `Choose a tag` and enter your version name and click the tag or `+create new tag on publish` if you are versioning manually
* From the [release](https://github.com/articulate/aws-eventbridge-action/releases)
page, Click `Draft a new release`
* Click `Choose a tag` and enter your version name and click the tag or
`+create new tag on publish` if you are versioning manually
* Enter the version name as the `Release Title`
* Click the Generate release notes to populate the description
* Assuming applicable, leave `Set as the latest release` clicked
Expand All @@ -62,21 +66,25 @@ Alternatively, you can use the gh client.

### Releasing / Scripted Method (Optional)

For a more automated experience, we recommend mloberg's git-release extension to tag your release. Requires GitHub cli `gh` and `git` to be installed locally.
For a more automated experience, we recommend mloberg's git-release extension to
tag your release. Requires GitHub cli `gh` and `git` to be installed locally.

* [git-release](https://github.com/mloberg/dotfiles/blob/main/bin/git-release)
* Drop the script in a local path and make sure it's executable
* Run `git release patch` or `get release minor` etc to generate the next tag for your release, push it up, and create a release complete with notes. (check script for more syntax options)
* Run `git release [type] --release` to generate the next tag for your release,
push it up, and create a release complete with notes. (check script for more
syntax options)

### Update the major version tag

Some actions will reference this using the _v1_ tag. We will need to update that tag locally and force push it.
Some actions will reference this using the _v2_ tag. We will need to update that
tag locally and force push it.

Then, update the v1 tag to point to the current commit.
Then, update the v2 tag to point to the current commit.

```shell
git checkout main
git pull
git tag -fa v1 -m "Update v1 tag"
git push origin v1 --force
git tag -fa v2 -m "Update v2 tag"
git push origin v2 --force
```
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ outputs:
event-id:
description: The event ID from AWS EventBridge.
runs:
using: node16
using: node20
main: dist/index.js
branding:
color: blue
Expand Down
6,799 changes: 3,889 additions & 2,910 deletions dist/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

61 changes: 30 additions & 31 deletions dist/licenses.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2cb1690

Please sign in to comment.