Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main unstable #91

Open
wants to merge 15 commits into
base: main_unstable
Choose a base branch
from
Open

Conversation

rmcolq
Copy link
Collaborator

@rmcolq rmcolq commented Mar 7, 2025

Closes a number of small outstanding issues.

  1. Adds a script to check the input file where a single fastq file is provided, so that it can warn if there are duplicate headers. This was seen in some example data and would cause big problems for the viral reclassification step when run, as read names need to be unique. If it finds duplicate/unexpectedly interleaved files, tries to correct them but then exists. The user can try rerunning with the fixed files. I considered silently handling but this approach seemed dangerous.
  2. Add messaging if paired reads provided and --paired not.
  3. Add a workflow to run modules (it didn't work to add projectDir to script path as this is within the modules directory when a module is run). Also remove workflow definitions from these modules
  4. Add total_len for input and output files
  5. Add a warning for incorrect Phred parsing as this is thought to be a resolved issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant