Artex master #7
Open
Artex master #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.17.0. - [Commits](golang/crypto@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
use default instead of a timer refactor send queued In case of Log On messages block until sent
…til sent (quickfixgo#21) ## Issue When log on request was queued because cannot be send due to connection not ready, Then it goes through the [main session loop](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session.go#L821-L841) which leads to [SendAppMessages](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session_state.go#L107-L111) But, since session is not logged on yet because the message queued is the log on message, we drop the `toSend` queued messages so we lose the log on message itself. ## Proposed solution For important messages like Logon/Logout/Resend/SequenceReset we block until sent.
partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
Update and satisfy code linter
…anced-incorrectly Group field whose elements do not have the same fields are incorrectly parsed
…en-blocked Escape send queued when blocked on connection side
feat: change proxyproto pkg to support proxy proto v2
Bug: For Logon/Logout/Resend/SequenceReset messages we should wait until sent
…es/golang.org/x/crypto-0.17.0 Bump golang.org/x/crypto from 0.15.0 to 0.17.0
Adds v0.9.2 release notes
feat: AllowUnknownMessageFields & CheckUserDefinedFields
Corrects ResetOnLogon for initiators
Unregistering sessions on stop
v0.9.5 release notes
…ls-config-for-acceptor Allow the clients of acceptor to specify their own tls.Config
Adds NextExpectedSeqNum setting
Reinit stop sync to prevent deadlock on sequential start/stops
…nauth Check logon auth before resetting store
Reverts ToAdmin call sequencing
Adds SQL, Mongo, and Composite Log Implementations
Adds convenience getters for session log and store
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Signed-off-by: Sylvain Rabot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.