Fix accession type option in clipboard export #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the type would fall back to informationObject when the selected type was accession.
Contributor
Author
|
Looks like a network issue cause the Electron integration tests to fail. I don't have permission to retry the job but I'd expect it to succeed if it was retried |
sarah-mason
added
the
Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2221
Closes #2222
These issues are closely related so I addressed them both in this PR.
There is some JS that watches for changes in the Type selector on the clipboard export page, and "accession" was not one of the expected types, so it always fell back to "informationObject". This is why it wasn't possible to select the Accession option.
And now I'm only showing the Accession option in that dropdown when the user is an editor or admin.