Add CSP Headers to AtoM Responses #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbreker
force-pushed
the
dev/csp-headers
branch
5 times, most recently
from
e2b7984
to
9516f16
Compare
sbreker
force-pushed
the
dev/csp-headers
branch
2 times, most recently
from
19169e5
to
6785ce4
Compare
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/accession/templates/_alternativeIdentifiers.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/accession/templates/_events.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/accession/templates/_relatedDonor.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/accession/templates/browseSuccess.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/actor/templates/_occupations.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/informationobject/templates/_childLevels.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/informationobject/templates/_identifierOptions.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/informationobject/templates/multiFileUploadSuccess.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/repository/templates/_uploadLimit.php
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/repository/templates/_uploadLimit.php
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/repository/templates/_uploadLimit.php
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/sfDcPlugin/templates/_dcDates.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/sfDcPlugin/templates/_dcNames.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/sfDcPlugin/templates/editSuccess.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/sfIsadPlugin/templates/_event.php
Outdated
Show resolved
Hide resolved
sbreker
commented
Sep 27, 2023
plugins/arDominionB5Plugin/modules/sfModsPlugin/templates/editSuccess.php
Outdated
Show resolved
Hide resolved
FitiaHarena
force-pushed
the
dev/csp-headers
branch
2 times, most recently
from
9bb3718
to
0a8df9f
Compare
jraddaoui
reviewed
Oct 3, 2023
plugins/arDominionB5Plugin/modules/accession/templates/_alternativeIdentifiers.php
Show resolved
Hide resolved
FitiaHarena
force-pushed
the
dev/csp-headers
branch
from
25e03f8
to
52f6ee9
Compare
sbreker
force-pushed
the
dev/csp-headers
branch
2 times, most recently
from
9e966b2
to
dbfb107
Compare
sbreker
force-pushed
the
dev/csp-headers
branch
from
dbfb107
to
9d39065
Compare
|
Hi @jraddaoui and @anvit - this is ready for code review. Because of some decision changes during the course of development, it is easiest to review using the "files changed" view. |
anvit
approved these changes
Oct 11, 2023
jraddaoui
requested changes
Oct 16, 2023
|
Hi @jraddaoui - thanks for your feedback! @FitiaHarena and I have added commits to address the items you mentioned... ready for re-review. 👍 |
sbreker
force-pushed
the
dev/csp-headers
branch
from
4fc81d0
to
86a2f92
Compare
Add Content Security Policy (CSP) headers to AtoM responses when B5 themes are enabled. The 'app_csp_reponse_header' setting is used to switch between using 'Content-Security-Policy-Report-Only' or 'Content-Security-Policy' headers. Deleting the setting will disable CSP headers. The default setting for 'app_csp_reponse_header' is 'Content-Security-Policy' so CSP headers will be added to AtoM responses by default. The 'app_csp_directives' setting is used to tweak the actual header contents. If this setting is not present CSP headers will be disabled. Co-authored-by: FitiaHarena <[email protected]>
sbreker
force-pushed
the
dev/csp-headers
branch
from
86a2f92
to
d796a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Content Security Policy (CSP) headers to AtoM responses when B5 themes are enabled.
The 'app_csp_reponse_header' setting is used to switch between using 'Content-Security-Policy-Report-Only' or 'Content-Security-Policy' headers. Deleting the setting will disable CSP headers.
The 'app_csp_directives' setting is used to tweak the actual header contents.