Defer FPRule counter updates during normalization #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/issue-752-fprule-counter-deadlock-fix
branch
from
3aadaa8
to
09ed00e
Compare
|
An interesting aspect of this pull request is that I've never been able to reproduce the original issue, so I'm uncertain if this change is necessary or whether it solves the problem. I've tested multiple batch sizes, number of worker replicas and transfers with hundreds of files unsuccessfully, but the issue has occasionally been experienced by both customers and the Artefactual team. Maybe we can keep this work around until needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a context manager (
DeferredFPRuleCounter) to defer the tracked FPRule execution until thecallfunction completes the execution of the entire batch, reducing the risk of deadlocks when multiple MCPClients attempt to update the same FPRule concurrently.This change helps prevent deadlocks, but keep in mind that normalize.py might be reworked later to avoid using long database transactions altogether.
Tentative fix for archivematica/Issues#752 and archivematica/Issues#1525.
Relates to archivematica/Issues#1161.