Upgrade Django to 4.2 #1847
Merged
Upgrade Django to 4.2 #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
added
AMAUAT
src/dashboard/src/components/administration/tests/test_dip_upload_configs.py
Show resolved
Hide resolved
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
2 times, most recently
from
0b5d161
to
b1f02e5
Compare
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
2 times, most recently
from
1c467ea
to
52ad358
Compare
Dhwaniartefact
added
AMAUAT
|
This looks good @Dhwaniartefact, thanks! Let's leave this PR here until we milestone its issue. |
Django 4.2 optimisation replace regex based method match() from parse_datetime ref: https://code.djangoproject.com/ticket/32892
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
from
4347f29
to
642a2f7
Compare
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
from
642a2f7
to
737b4b3
Compare
Dhwaniartefact
added
AMAUAT
replaceafill
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets django-upgrade in pre-commit to upgrade Django to 4.2.
One significant change is:
The Django 4.2 version uses a datetime method called fromisoformat() to get well-formed values for timezone in parse_datetime() of dateparse module.
Ref: https://github.com/django/django/blob/main/django/utils/dateparse.py#L104
Connected to archivematica/Issues#1624