-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Django to 3.2 #1833
Merged
Merged
Upgrade Django to 3.2 #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
added
AMAUAT
Issues relating to the improvement of the AM Automated Acceptance tests
and removed
AMAUAT
Issues relating to the improvement of the AM Automated Acceptance tests
labels
Aug 20, 2023
Dhwaniartefact
approved these changes
Aug 21, 2023
replaceafill
force-pushed
the
dev/issue-1279-django32
branch
from
August 21, 2023 20:26
6117591
to
879d8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets
django-upgrade
inpre-commit
to upgrade Django to 3.2. Python requirements have been upgraded to compatible versions too.Two changes are worth highlighting:
main.models.BlobTextField
used to represent some paths has been replaced with Django'sBinaryField
. Combining Django 3.2TextField
with the MySQL'slongblob
type like the custom field does is not possible anymore since Django writes (and overwrites) Python's binary representation to the database. Switching toBinaryField
allow us to keep using the same MySQL type without requiring data migrations, and makes the binary-type nature of those fields explicit in the Python code.compilemessages
command didn't fail when it was not able to write*.mo
files due to permissions. In Django 3.2 the command fails interrupting the Docker build. That's why this sets ownership of thelocale/**/LC_MESSAGES
directories to thearchivematica
user explicitly.Depends on artefactual-labs/archivematica-acceptance-tests#185
Connected to archivematica/Issues#1279