Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development environment fixes #1831

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Development environment fixes #1831

merged 5 commits into from
Jul 24, 2023

Conversation

replaceafill
Copy link
Member

This fixes a few problems identified after the 1.14 release:

  • Removes a workaround in the AMAUATs CI workflow caused by Compose 2.19.0 that prevented services to be restarted
  • Sets the home directory of the archivematica user and the pyenv root directory outside of the /home directory to avoid exposing files to the external volumes
  • Sets permissions on test databases only instead of creating them on each test run which integrates better with pytest-django

Connected to archivematica/Issues#1613

@replaceafill replaceafill requested a review from a team July 21, 2023 18:50
@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Jul 21, 2023
sevein
sevein approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the docker compose restart issue yesterday, thanks for the fix! 👍

@replaceafill replaceafill merged commit 279c190 into qa/1.x Jul 24, 2023
10 checks passed
@replaceafill replaceafill deleted the dev/dev-env-fixes branch July 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevein sevein sevein approved these changes

@Dhwaniartefact Dhwaniartefact Awaiting requested review from Dhwaniartefact

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@replaceafill @sevein