Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on arquillian-core testjars #286 #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhusar
Copy link
Collaborator

@rhusar rhusar commented Jan 24, 2025

No description provided.

@WolfgangHG
Copy link
Contributor

So you copied the arquillian base tests - same as I did locally to verify that they work ;-).

Could we keep this pull request on hold or even close it? Then I would apply the same change to my junit5 branch. Otherwise I end up in merge hell...

@rhusar rhusar force-pushed the testjars-dependency branch from 29bfd24 to 23fa7b1 Compare January 24, 2025 21:18
@rhusar
Copy link
Collaborator Author

rhusar commented Jan 24, 2025

Uh I just realized we don't have to change the class names, which makes the change even smaller and easily reversible (if we ever get to that point).

@rhusar
Copy link
Collaborator Author

rhusar commented Jan 24, 2025

So you copied the arquillian base tests - same as I did locally to verify that they work ;-).

Could we keep this pull request on hold or even close it? Then I would apply the same change to my junit5 branch. Otherwise I end up in merge hell...

If you did the same, then it will rebase cleanly. I did add documentation for each package.

Anyway, this is mergeable as is... but sure can keep this open.

@WolfgangHG
Copy link
Contributor

WolfgangHG commented Jan 25, 2025

I added your changes to my fork (converted to JUnit5): WolfgangHG@577736c

But before creating a pull request, I have to fix the mockito stubbing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants