-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resume Docker integrations tests #1317
Conversation
…ke the desired request base path into account
…r existing jonmorehouse/ping-pong Docker image
…docker/assertj/pom.xml
…, for classloader to include javax.*
… computed, since java.nio.Paths in JDK 11 does not allow for URI with null schema
… from 7 to 10, from 6 to 9 where a previous version is used In docker functional tests: switch from javax.* to jakarta.* in deployments, in order to let containers provide depoyments which byteconde is compatible with JDK 11
…-v2 tests, switch from javax.* to jakarta.* in deployments, in order to let containers provide depoyments which byteconde is compatible with JDK 11, make the Tomcat manager app available in deployments, and relax the Tomcat 10 context.xml file requirements to allow connections routed from the container host IP address
…order to use the well maintained fork om.github.mwiede/jsch, which allows for more recently generated private keys
…ker-containerobject, and updating tests and resources accordingly, since dipakpawar231/proftpd:v1 is no longer available
…g image with the hashicorp/http-echo image
…-star-operator tests, switch from javax.* to jakarta.* in deployments, in order to let containers provide depoyments which byteconde is compatible with JDK 11
…git-context (https://github.com/lordofthejars/pingpongdockerfile.git) with https://github.com/tsongpon/pingpong.git, since the former points to the no longer available jonmorehouse/ping-pong
6c9d2e4
to
ba3a889
Compare
…g image with the tsongpon/pingpong image, where hashicorp/http-echo is tricky to configure due to commands, envs and docker compose combination
…est-standalone and docker/ftest-junit-rules. Also - in docker/ftest - bumping the WildFly version, and adding relaxed context.xml for Tomacat 10 to allow external connections, plus enabling the manager app
…est supported by docker-java 3.4.0
…-containerobject tests, since 5000 is already in use by GitHub runners that execute CI checks
ba3a889
to
49e0377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great unless some of my overcritical comments 👍 :)
1f33f18
to
283f322
Compare
…a more recent version for the setup-minikube step
283f322
to
2778630
Compare
Thanks for your review @gaol - actually pretty good points, so I've fixed the changes accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
This looks good to me . Nice work @fabiobrz ! |
The changes here aim at fixing the Docker integration tests after the recent updates, and to enable GitHub workflow based CI checks
Short description of what this resolves:
Fixing implementation after changes to support JDK 11, resuming Docker integration tests, upgrading dependencies where required, enabling proper CI check via GitHub workflow
The CI checks which are executed with the changes in this PR will actually execute Docker integration tests.
Changes proposed in this pull request:
javax.*
tojakarta.*
containerless
to 1.43, which is the latest supported by docker-java 3.4.0jonmorehouse/ping-pong
is replaced byhashicorp/http-echo:alpine
- thanks to the work done by @gaol in [issue:1303] Drop usage of unavailable docker image out of tests #1306 here - and bytsongpon/pingpong
, depending on the related configuration requirementsmanager
ap which is needed to deploy), and to the related test deployments, most notably moving fromjavax.*
tojakarta.*
have been introduced accordinglyFollow up issues
The following is a list of issues that have been logged as a follow up to the actions described above:
docker-compose
versions are actually supported, and document/test accordingly. Evaluate whether to reintroduce any docker v1 removal change which might have happened lately, also because the documentation states thata the CUBE format only support docker compose v1? Tracked by Clarify what docker-compose versions are actually supported #1319Fixes #1315, resolves #1302