Skip to content

Commit

Permalink
[issue-1323] - Fix OpenshiftAssisant to use base methods for awaiting…
Browse files Browse the repository at this point in the history
… application readiness, i.e. ReplicationController that is actually responding properly to Readiness
  • Loading branch information
fabiobrz committed Dec 23, 2024
1 parent c09feea commit d154bbe
Showing 1 changed file with 23 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,29 +146,29 @@ public void scale(final String applicationName, final int replicas) {
awaitApplicationReadinessOrFail(applicationName);
}

/**
* Awaits at most 5 minutes until all pods of the last deployed application are running.
*/
@Override
public void awaitApplicationReadinessOrFail() {
awaitApplicationReadinessOrFail(this.applicationName);
}

/**
* Awaits at most 5 minutes until all pods of the application are running.
*
* @param applicationName name of the application to wait for pods readiness
*/
@Override
public void awaitApplicationReadinessOrFail(final String applicationName) {
await().atMost(5, TimeUnit.MINUTES).until(() -> {
return getClient()
.deploymentConfigs()
.inNamespace(this.namespace)
.withName(applicationName).isReady();
}
);
}
// /**
// * Awaits at most 5 minutes until all pods of the last deployed application are running.
// */
// @Override
// public void awaitApplicationReadinessOrFail() {
// awaitApplicationReadinessOrFail(this.applicationName);
// }
//
// /**
// * Awaits at most 5 minutes until all pods of the application are running.
// *
// * @param applicationName name of the application to wait for pods readiness
// */
// @Override
// public void awaitApplicationReadinessOrFail(final String applicationName) {
// await().atMost(5, TimeUnit.MINUTES).until(() -> {
// return getClient()
// .deploymentConfigs()
// .inNamespace(this.namespace)
// .withName(applicationName).isReady();
// }
// );
// }

/**
* Method that returns the current deployment configuration object
Expand Down

0 comments on commit d154bbe

Please sign in to comment.