Render the esi tags with a template to be able to customize it depending... #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing on the context (e.g. pass in GET vars).
|
Hi, just wondering if you can explain to me what this does in more detail. To me, it just looks like this makes it easy for projects to have their own "esi/esi_tag.html" if they need to customize it on a project-wide level. |
|
@crccheck Yeah, exactly. Right now the template is hardcoded which makes it hard to modify how the URL is rendered. E.g. I may want to append a user specific GET var to be able to cache those includes on Varnish side. |
| if self.asvar: | ||
| url = context[self.asvar] | ||
|
|
||
| render_context = copy.copy(context) |
There was a problem hiding this comment.
Why fully copy the context instead of doing a context.push() before rendering the esi tag template and then popping the context afterwards?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on the context (e.g. pass in GET vars).