correct include for int64_t type #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdint.h is the C99-standardized header for fixed-size integers, not stdlib.h. this matters on systems that build against musl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdint.his the C99-standardized header for fixed-size integers, notstdlib.h.this matters on systems that build against musl. other than that, I had no issues building lingeling.
I'm not sure what the scope of target platforms of lingeling is, so I will note that this may break builds on other platforms, like old versions of MSVC. it may be preferred to instead detect if this change is necessary in the configure script and/or through the preprocessor.