Skip to content

Radxa-e52c: reopen disabled nodes for mainline u-boot#9379

Open
okrc wants to merge 1 commit intoarmbian:mainfrom
okrc:radxa-e52c
Open

Radxa-e52c: reopen disabled nodes for mainline u-boot#9379
okrc wants to merge 1 commit intoarmbian:mainfrom
okrc:radxa-e52c

Conversation

@okrc
Copy link
Member

@okrc okrc commented Feb 9, 2026

⚠️ Warning

Please test if it works properly.

Summary by CodeRabbit

  • Chores
    • Bootloader behavior on RK3582/RK3588 boards adjusted: several automatic core-failure policies have been disabled while diagnostic logging of core states remains active. This changes how the bootloader reports and responds to individual core faults during startup, preserving logs but preventing previously enforced cluster-level or per-core shutdown actions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 90169ba and fb91efe.

📒 Files selected for processing (1)
  • patch/u-boot/v2026.01/board_radxa-e52c/9000-reopen-disabled-nodes-for-rk3582.patch
🚧 Files skipped from review as they are similar to previous changes (1)
  • patch/u-boot/v2026.01/board_radxa-e52c/9000-reopen-disabled-nodes-for-rk3582.patch

📝 Walkthrough

Walkthrough

Two conditional policy blocks in the Rockchip RK3588 implementation were wrapped with #if 0/#endif, disabling compile-time enforcement of certain core/cluster failure policies while leaving surrounding logging and structure intact.

Changes

Cohort / File(s) Summary
RK3588 policy toggled off
arch/arm/mach-rockchip/rk3588/rk3588.c
Wrapped two policy code sections with #if 0 / #endif, disabling logic that would fail the big-core cluster and an rkvenc core on RK3582 variants; preserved logging and surrounding control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I nudged some guards to sleep tonight,

Wrapped policies in quiet light,
Big cores rest and encoders stay,
A soft compile-time holiday,
I nibble bugs and hop away.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Radxa-e52c: reopen disabled nodes for mainline u-boot' directly aligns with the patch, which reopens (uncomments) previously disabled policy logic in the rk3588.c file for Radxa-e52c hardware.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Feb 9, 2026
@igorpecovnik igorpecovnik added the Help needed We need your involvement label Feb 20, 2026
@igorpecovnik
Copy link
Member

We need a test to confirm - i don't have this hardware.

Signed-off-by: okrc <okrc@hexo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Help needed We need your involvement Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants