control armbian-common: move fdisk and parted to Depends, needed for armbian-resize-filesystem

[tabrisnet]

what it says on the tin: armbian-resize-filesystem needs both fdisk & parted

[coderabbitai]

Walkthrough

This change modifies the debian/control file for the armbian-common package, promoting two package dependencies from Recommends to Depends. Specifically, fdisk and parted are moved from optional recommended packages to required hard dependencies, meaning they will be automatically installed when armbian-common is installed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Single file affected with straightforward, mechanical changes
• Verify that fdisk and parted should be hard requirements rather than recommendations for the Armbian use case
• Confirm the dependency change aligns with project goals and doesn't introduce unnecessary bloat

Suggested labels

02, Needs review

Suggested reviewers

• leggewie

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: moving fdisk and parted from Recommends to Depends in the armbian-common package, and clearly states the reason (needed for armbian-resize-filesystem).
Description check	✅ Passed	The description is directly related to the changeset, explaining why the dependencies need to be moved (armbian-resize-filesystem requires both tools) and references the relevant script.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d1e4a5d and 5f5c286.

📒 Files selected for processing (1)

• debian/control (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: tabrisnet
Repo: armbian/apa PR: 25
File: debian/control:23-23
Timestamp: 2025-12-06T21:01:15.488Z
Learning: In the armbian/apa repository's debian/control, iputils-ping is temporarily added to armbian-common's Depends as a workaround for a capability issue where /bin/ping cannot create raw sockets. The proper solution involves: (1) PR #27, (2) removing the chmod u+s workaround code from armbian/build (armbian/build#9033), and (3) adding libcap2-bin to armbian/build's debootstrap package list so that iputils-ping's postinst script can use setcap to properly configure /bin/ping. Once these pieces are complete and merged, iputils-ping should be removed from armbian-common's Depends as it will no longer be needed.

📚 Learning: 2025-12-06T21:01:15.488Z

Learnt from: tabrisnet
Repo: armbian/apa PR: 25
File: debian/control:23-23
Timestamp: 2025-12-06T21:01:15.488Z
Learning: In the armbian/apa repository's debian/control, iputils-ping is temporarily added to armbian-common's Depends as a workaround for a capability issue where /bin/ping cannot create raw sockets. The proper solution involves: (1) PR #27, (2) removing the chmod u+s workaround code from armbian/build (armbian/build#9033), and (3) adding libcap2-bin to armbian/build's debootstrap package list so that iputils-ping's postinst script can use setcap to properly configure /bin/ping. Once these pieces are complete and merged, iputils-ping should be removed from armbian-common's Depends as it will no longer be needed.

Applied to files:

• debian/control

🔇 Additional comments (1)

debian/control (1)

19-37: Promotion of fdisk and parted to hard Depends matches the script’s hard requirements

Given that armbian-resize-filesystem needs both fdisk and parted to operate, moving them from Recommends to Depends is appropriate: installs of armbian-common will now have the tools the script assumes, avoiding runtime failures on systems that skip recommended packages. The control stanza syntax (commas, ordering) also looks correct. This does increase the minimal base footprint, but unlike the temporary iputils-ping workaround noted in earlier PRs, these appear to be genuine, long‑term runtime dependencies, so the trade‑off seems justified. Based on learnings, this change looks good as-is.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tabrisnet]

This could be refactored into lib/functions/bsp/armbian-bsp-cli-deb.sh#L285, with the caveat that it is universal enough to belong in the rootfs tarball.

[leggewie]

This could be refactored into lib/functions/bsp/armbian-bsp-cli-deb.sh#L285, with the caveat that it is universal enough to belong in the rootfs tarball.

I agree that this should be added to the BSP depends. I shall open a PR to that effect. I am happy to add those two to Recommends in armbian-commonas well. I will push such a change shortly.

[leggewie]

On second thought, this should be added not to the BSP Depends but to whatever package ships armbian-resize-filesystem