add armbian-desktop-cinnamon & armbian-desktop-i3-wm

[leggewie]

carve out from #25

add cinnamon and i3m DE packages. Not sure yet, if we really want to do that.

[coderabbitai]

Walkthrough

Three new Armbian Desktop metapackages are added to debian/control: armbian-desktop-cinnamon, armbian-desktop-i3-wm, and armbian-desktop-kde. Each package is architecture-independent, marked as optional, provides armbian-desktop, and includes breaks/conflicts declarations against armbian-desktop. All three depend on armbian-desktop-common and their respective desktop environment packages (cinnamon-core or ubuntucinnamon-desktop-minimal for Cinnamon, i3-wm for I3, and kde-plasma-desktop for KDE).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify package names and version correctness for desktop environment dependencies (cinnamon-core, ubuntucinnamon-desktop-minimal, i3-wm, kde-plasma-desktop)
• Confirm provides/breaks/conflicts declarations are consistent across all three new packages and don't create circular dependencies
• Validate that armbian-desktop-common is a valid dependency target for all variants

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main changes: adding two new Armbian Desktop metapackages (Cinnamon and I3 window manager).
Description check	✅ Passed	The description is related to the changeset, mentioning that it adds Cinnamon and I3 DE packages, though it lacks detail about the complete changes including KDE.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch wip-add-cinnamon-and-i3m

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

debian/control (2)

92-103: Consider adding Recommends for essential Cinnamon components.

The package currently has minimal dependencies. While ubuntucinnamon-desktop-minimal may include necessary components, users installing cinnamon-core (the fallback option) might lack essential functionality. Consider adding a Recommends section similar to other desktop packages:

• Display manager (e.g., lightdm or slick-greeter)
• File manager (e.g., nemo)
• Terminal emulator (though covered by armbian-desktop-common)
• Cinnamon settings and applets

This would ensure a more complete desktop experience while maintaining the flexibility of a metapackage.

 Depends:
  armbian-desktop-common,
  ubuntucinnamon-desktop-minimal|cinnamon-core,
  ${misc:Depends}
+Recommends:
+ lightdm,
+ nemo,
+ cinnamon-control-center

---

106-117: Consider adding Recommends for i3 ecosystem components.

While i3-wm users often prefer minimal setups, consider adding a Recommends section for essential i3 ecosystem tools and a display manager to ensure the window manager can actually start:

• Display manager (e.g., lightdm) - required to start X sessions
• Status bar (e.g., i3status or i3blocks)
• Application launcher (e.g., dmenu or rofi)
• Lock screen (e.g., i3lock)

This provides a working baseline while allowing experienced users to remove components they don't need.

 Depends:
  armbian-desktop-common,
  i3-wm,
  ${misc:Depends}
+Recommends:
+ lightdm,
+ i3status,
+ dmenu,
+ i3lock

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a30dbbd and 473e451.

📒 Files selected for processing (1)

• debian/control (1 hunks)

🔇 Additional comments (2)

debian/control (2)

120-130: AI summary incorrectly claims KDE is new in this PR.

The AI summary states "Three new Armbian Desktop metapackages are added" including armbian-desktop-kde, but the code annotations show the KDE package definition (lines 120-130) has no changes (no ~ markers). The PR title confirms only Cinnamon and I3-WM are being added.

---

101-101: No action required. The current packaging correctly uses Debian alternative dependencies (ubuntucinnamon-desktop-minimal|cinnamon-core) to handle cross-distro compatibility. On Debian systems lacking ubuntucinnamon-desktop-minimal, apt will automatically resolve to cinnamon-core. This is standard Debian packaging practice.

[tabrisnet]

either we do this, or remove them [whether one or both] from config/desktop.