Skip to content

remove useless modular operation #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

remove useless modular operation #982

merged 1 commit into from
Jun 17, 2025

Conversation

zhiqiangxu
Copy link
Contributor 

for i in 0..N {
...
}

In this context, i is already [0, N), so there's no need for % N.

@zhiqiangxu zhiqiangxu requested review from a team as code owners May 9, 2025 04:12
@zhiqiangxu zhiqiangxu requested review from z-tech, Pratyush and weikengchen and removed request for a team May 9, 2025 04:12
@Pratyush Pratyush added this pull request to the merge queue Jun 17, 2025
Merged via the queue into arkworks-rs:master with commit a6ee3a9 Jun 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech z-tech approved these changes

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @z-tech @Pratyush