Apply rename migration to example users: System -> system #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これ S2E に対して breaking だな |
どうしよ． S2E core ？ user なら S2E for minimum user を fork なんですが． |
のどっちかかな |
|
ただここで問題なのは，当然 s2e-core に対する修正は c2a-core v3 に対して breaking |
あいや，これは |
|
今，さまざまなbrakingをやってるので，CIがコケてる状態でマージはしたくないなぁ． |
|
これ，S2E userのみでは解消不能なんだっけ？（s2e-core修正必須？） |
|
s2e-core problem ですね |
|
むしろ S2E user は修正要らないな |
これやるしかなさそう？ |
This was referenced Aug 16, 2023
sksat
force-pushed
the
feature/rename-system-dir-to-snake-case
branch
from
156a48d
to
3bf0e7a
Compare
sksat
force-pushed
the
feature/rename-system-examples
branch
from
3841e89
to
c3cb18d
Compare
|
#54 を更新したので rebase |
sksat
force-pushed
the
feature/rename-system-examples
branch
from
fec492c
to
293d4b5
Compare
|
正しく re-run するために force push（c2a-enum-loader 対応） |
Base automatically changed from
feature/rename-system-dir-to-snake-case
to
develop
August 25, 2023 08:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
System->systemへの migration を example user に適用したIssue / PR