Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rename migration to example users: Script -> script #39

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Aug 2, 2023

概要

Script -> script への migration を Example user に適用した

Issue / PR

@sksat sksat added enhancement New feature or request tools labels Aug 2, 2023
@sksat sksat self-assigned this Aug 2, 2023
@meltingrabbit
Copy link
Member

手元で確認してないんだけども,git revision 埋め込みとかも動いてるよね?(壊れる可能性あるよなぁとおもったけど,CI通ってれば大丈夫か?)

@sksat
Copy link
Member Author

sksat commented Aug 2, 2023

今は CMake から明示的に呼び出してて,動いてなかったらビルドコケるんで大丈夫です > git revision 埋め込み

Copy link
Member

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おつかれ

Base automatically changed from feature/rename-script-dir-to-snake-case to develop August 2, 2023 08:58
@sksat
Copy link
Member Author

sksat commented Aug 2, 2023

あれ,conflict した

@sksat
Copy link
Member Author

sksat commented Aug 2, 2023

subobc やり直し

@sksat sksat force-pushed the feature/rename-script-examples branch from 8100720 to e49c0d7 Compare August 2, 2023 09:02
@sksat sksat force-pushed the feature/rename-script-examples branch from e49c0d7 to ca5aede Compare August 2, 2023 09:05
@sksat
Copy link
Member Author

sksat commented Aug 2, 2023

rebase してやり直した

@sksat
Copy link
Member Author

sksat commented Aug 2, 2023

CI 通ったのでマージ

@sksat sksat merged commit 418e99e into develop Aug 2, 2023
24 checks passed
@sksat sksat deleted the feature/rename-script-examples branch August 2, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants