MOBC を想定した機能を有効化するためのビルドオプションを追加 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
sksat
reviewed
Feb 5, 2024
meltingrabbit
commented
Feb 5, 2024
meltingrabbit
force-pushed
the
feature/add_mobc_subobc_build_option
branch
from
bfd3041
to
49651fe
Compare
meltingrabbit
force-pushed
the
feature/add_mobc_subobc_build_option
branch
3 times, most recently
from
7ef6111
to
0b8e8e9
Compare
meltingrabbit
force-pushed
the
feature/add_mobc_subobc_build_option
branch
from
0b8e8e9
to
9a7f6bf
Compare
sksat
reviewed
Mar 28, 2024
sksat
reviewed
Mar 28, 2024
docs/general/build_options.md
Outdated
|
|
||
|
|
||
| #### `C2A_USE_ALL_CORE_TEST_APPS` | ||
| `ON` にすることで，全ての [Core Test Application](/applications/test_app/) をビルドする． |
There was a problem hiding this comment.
Core hoge は対象が一意に定まらないので，あくまで c2a-core と表記したい
Suggested change
| `ON` にすることで，全ての [Core Test Application](/applications/test_app/) をビルドする． | |
| `ON` にすることで，全ての [c2a-core Test Application](/applications/test_app/) をビルドする． |
sksat
reviewed
Mar 28, 2024
docs/general/build_options.md
Outdated
There was a problem hiding this comment.
このドキュメントそんなに要りますかね．無くていいというつもりは無いけれど，これぐらいの何も言ってなさなら CMakeLists.txt の先頭を見たり，そこにコメントがあったりする方が読む方も書く方も速いと思うんですが．メンテしにくいし．
sksat
reviewed
Mar 28, 2024
|
@sksat ドキュメントはPR分離します． ドキュメントの必要性ですが，c2a userのみを使うような人には，これはあったほうがいいと思います．たとえば． |
meltingrabbit
force-pushed
the
feature/add_mobc_subobc_build_option
branch
from
4ed678d
to
4130dff
Compare
meltingrabbit
force-pushed
the
feature/add_mobc_subobc_build_option
branch
from
4130dff
to
a66034e
Compare
|
@sksat docsをのぞきました（rebaseした） |
sksat
approved these changes
Mar 29, 2024
sksat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#305 のための準備．
デフォルト実装を core で提供するとき，MOBC か sub OBC かのどちらを意図してるコードかを切り替えるために用いる
あわせて，ビルドオプションのドキュメントも多少整備した．
Issue
NA
影響範囲
この PR ではこのオプションを利用するコードは追加されてないため，なし
備考