Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename component: DriverSuper -> Framing #115

Closed
wants to merge 18 commits into from

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 5, 2023

概要

  • Drivers/ 以下のものを rename する

Issue

詳細

  • この rename はあくまで c2a-core 内部の話.C2A user の Driver ディレクトリは(役割が違うため)変更しない
  • ディレクトリ: framing/ に統一する
    • Drivers/Super/ -> framing/
    • Drivers/Protocol -> framing/
  • 型・識別子
    • DriverSuper -> Framing
    • DS_ prefix -> FRM_ prefix
    • DSC_ prefix -> FRMC_ prefix
    • DSSC_ prefix -> FRMSC_ prefix

検証結果

test へのリンクや,検証結果へのリンク

影響範囲

XX系の動作がガラッと変わる,とか.

補足

#116 のマージ後,beta release したい

@sksat sksat added enhancement New feature or request priority::high priorityg high labels Oct 5, 2023
@sksat sksat self-assigned this Oct 5, 2023
@sksat
Copy link
Member Author

sksat commented Oct 5, 2023

今 check_coding_rule が落ちているのは check_coding_rule.pyFraming の型情報を発見できていないから(なので最悪 user 部分まで rename しないと通らないかも)

@sksat sksat marked this pull request as ready for review October 5, 2023 12:50
@sksat sksat changed the title Rename driver super Rename component: DriverSuper -> Framing Oct 5, 2023
@sksat sksat marked this pull request as draft October 12, 2023 09:25
@sksat
Copy link
Member Author

sksat commented Oct 12, 2023

c2a-core v4.0.0 ではやらない: #8 (comment)

@sksat sksat removed the priority::high priorityg high label Oct 12, 2023
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

Drivers ディレクトリの構造の整理は #122, #124 でやった.framing ライブラリの分割は v4.0.0 より後に #145 でやっていくため,閉じ

@sksat sksat closed this Oct 13, 2023
@sksat sksat deleted the feature/rename-driver-super branch October 13, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants