Issue141 #306
Merged
Issue141 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd updated readme to match new access method for the colrc local view
* Updated formatting to align with Prettier * Updated Accordion files to align with Prettier * Updated components to Align with Prettier * Updated to align with Prettier * Updated ALL files in frontend/src/pages (with the exception of Odinsonsearch.js) to align with Prettier * Updated queries.js to align with Prettier * Updated table-styles.js to align with Prettier * Updated /fonts/ to align with Prettier (This might mess something up) * Updated ALL files in /src/utils/ to align with Prettier (With the exception of PostLogin.js) * Updated App.js and App.test.js to align with Prettier * Updated ALL files in /src/ to align with Prettier * Fixed linting issue * fixed linting issue cause by refactor * Fixed linting issue caused by Prettier * Fixed linting issues caused by Prettier * Updated files in/file_upload/ to align with Prettier * Updated files in /auth/ to align with Prettier * Updated all files to align with Prettier (This changes them to Object Literal Syntax, fyi) * Updated files to align with Prettier (This changes them to Object Literal Syntax, fyi) --------- Co-authored-by: Walker White <[email protected]>
amyfou
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged my branch with issue #254, which was also concerned with implementing code changes via prettier standards. Any merge conflicts with this branch were resolved, and I then manually ran prettier on the required *Table.js files to also have them align with prettier. Additionally, changes were made to the README file so that it properly reflected the steps required to get the local version of the database to run.
These changes should make the code easier to read and work with, as well as enforcing a standard method of styling to promote uniformity in the code.
The functionality of the database was tested manually before and after these changes by running docker-compose -f docker-compose.yml -f docker-compose.override.yml up --build both before and after merging and implementing prettier changes and then going through the build locally to ensure that all functionality was maintained. In the future, it may be a good idea to create an issue involving setting it up so that prettier changes will happen automatically, rather than requiring a manual invocation.
*notes were made inside the readme regarding how to manually invoke prettier in the meantime.