Skip to content

Parse MSB and LSB from pitch bend and song position messages when using midilib gem #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Parse MSB and LSB from pitch bend and song position messages when using midilib gem #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abb9bc0
Parse MSB and LSB from pitch bend messages when using midilib gem.
mike-bourgeous Jan 29, 2023
49895c0
Use both data bytes of song position messages to create MIDILib events.
mike-bourgeous Feb 5, 2023
fcd1518
Fix midilib spec to use two 7-bit bytes for song position pointer.
mike-bourgeous Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/nibbler/midilib.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,16 @@ def channel_aftertouch(second_nibble, data_byte)
end

def pitch_bend(second_nibble, data_byte1, data_byte2)
# to-do handle the midilib lsb/msb
# right now the second data byte is being thrown away
MIDI::PitchBend.new(second_nibble, data_byte1, data_byte2)
MIDI::PitchBend.new(second_nibble, data_byte2 * 128 + data_byte1)
end

def system_exclusive(*args)
MIDI::SystemExclusive.new(args)
end

def system_common(second_nibble, data_byte1 = nil, _data_byte2 = nil)
def system_common(second_nibble, data_byte1 = nil, data_byte2 = nil)
case second_nibble
when 0x2 then MIDI::SongPointer.new(data_byte1) # similar issue to pitch bend here
when 0x2 then MIDI::SongPointer.new(data_byte2 * 128 + data_byte1)
when 0x3 then MIDI::SongSelect.new(data_byte1)
when 0x6 then MIDI::TuneRequest.new
end
Expand Down
10 changes: 4 additions & 6 deletions spec/integration/midilib_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,12 @@
end

context 'when pitch bend' do
# to-do handle the midilib lsb/msb
# right now the second data byte is being thrown away
let(:message) { lib.pitch_bend(0x0, 0x20, 0x00) }
let(:message) { lib.pitch_bend(0x0, 0x10, 0x3f) }

it 'returns correct message' do
expect(message).to be_a(MIDI::PitchBend)
expect(message.channel).to eq(0)
expect(message.value).to eq(0x20)
expect(message.value).to eq(8080)
end
end

Expand All @@ -91,11 +89,11 @@
end

context 'when song pointer' do
let(:message) { lib.system_common(0x2, 0xF0) }
let(:message) { lib.system_common(0x2, 0x6d, 0x01) }

it 'returns correct message' do
expect(message).to be_a(MIDI::SongPointer)
expect(message.pointer).to eq(0xF0)
expect(message.pointer).to eq(237)
end
end

Expand Down