fix: add parallel notification delivery #398
Closed
+730
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gblanc-1a
force-pushed
the
feature/parallel_notifications
branch
3 times, most recently
from
900d042 to
ba683ce
Compare
gblanc-1a
changed the title
gblanc-1a
force-pushed
the
feature/parallel_notifications
branch
3 times, most recently
from
5eb1bad to
389c952
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 55.41% 56.06% +0.64%
==========================================
Files 46 46
Lines 4125 4186 +61
==========================================
+ Hits 2286 2347 +61
Misses 1511 1511
Partials 328 328 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gblanc-1a
force-pushed
the
feature/parallel_notifications
branch
from
389c952 to
f6bdbb0
Compare
Implements parallel notification delivery with configurable concurrency Solve performance issues described in argoproj#146 and slow or failing destinations Adds maxConcurrentNotifications config option (default: 10) Signed-off-by: gblanc-1a <[email protected]>
gblanc-1a
force-pushed
the
feature/parallel_notifications
branch
from
f6bdbb0 to
ad2c6e5
Compare
|
Closed as not yet ready for reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have been encountering issues similar to what is described in #146. In my case one of the webservice in destination of the notification was not responding and was waiting for the timeout. With 3 retries this delayed significantely the time where other notification would be sent (which trigger argo workflow on our end)
This PR addresses this issue by allowing parallel notification.
For now I used a default of 50 parallel which might be high.
If we want to be on the safe side we could imagine keeping the default to 1 and allowing only the configuration.
The implementation should be backward compatible (except for the potential resource usage of the go routines hence my proposal above).
Existing configurations should work without changes, and the new
maxConcurrentNotificationssetting is optional for users who need custom tuning.