Fix: Use RFC3339 Timestamp Format and Add Missing Fields in GitHub CheckRun Payload #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahdi Bouaziz <[email protected]>
Signed-off-by: Mahdi Bouaziz <[email protected]>
Signed-off-by: Mahdi Bouaziz <[email protected]>
mahdibouaziz
force-pushed
the
github-time-parsing-and-missing-fields
branch
from
5dd491e to
07cb3a1
Compare
|
@crenshaw-dev @pasha-codefresh Can you take a look ? |
|
@blakepettersson can you take a look ? |
| return err | ||
| } | ||
| completedTime, err := time.Parse("YYYY-MM-DDTHH:MM:SSZ", notification.GitHub.CheckRun.CompletedAt) | ||
| completedTime, err := time.Parse(time.RFC3339, notification.GitHub.CheckRun.CompletedAt) |
There was a problem hiding this comment.
I think completedTime should be optional, so it will work when the Status is in_progress and completedTime shouldn't be set yet
| Name: notification.GitHub.CheckRun.Name, | ||
| DetailsURL: ¬ification.GitHub.CheckRun.DetailsURL, | ||
| Status: ¬ification.GitHub.CheckRun.Status, | ||
| Conclusion: ¬ification.GitHub.CheckRun.Conclusion, |
There was a problem hiding this comment.
the same here, need to make sure it can work when Conclusion is not set, because:
Required if you provide completed_at or a status of completed. The final conclusion of the check. Note: Providing conclusion will automatically set the status parameter to completed. You cannot change a check run conclusion to stale, only GitHub can set this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR addresses Issue #388, which affects GitHub CheckRun notifications in
argocd-notifications.Two problems were identified:
1.
started_atandcompleted_atfields failed to parse due to an incorrect time layout.2. The
statusandconclusionfields were omitted from the GitHub CheckRun payload, causing validation errors.Fix Details
"YYYY-MM-DDTHH:MM:SSZ"with the standardtime.RFC3339layout for parsingstarted_atandcompleted_at.statusandconclusionfields in the payload sent to the GitHub CheckRun API.Impact
This fix ensures that GitHub CheckRun notifications are correctly formatted and accepted by GitHub, restoring proper CI/CD deployment reporting.
Fixes #388