fix: deduplicate OpenAPI definitions for GVKParser (2.10) (#587) #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: deduplicate OpenAPI definitions for GVKParser Signed-off-by: Michael Crenshaw <[email protected]> * do the thing that was the whole point Signed-off-by: Michael Crenshaw <[email protected]> * more logs Signed-off-by: Michael Crenshaw <[email protected]> * don't uniquify models Signed-off-by: Michael Crenshaw <[email protected]> * schema for both Signed-off-by: Michael Crenshaw <[email protected]> * more logs Signed-off-by: Michael Crenshaw <[email protected]> * fix logic Signed-off-by: Michael Crenshaw <[email protected]> * better tainted gvk handling, better docs, update mocks Signed-off-by: Michael Crenshaw <[email protected]> * add a test Signed-off-by: Michael Crenshaw <[email protected]> * improvements from comments Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.