Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove out-of-date sections #248

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

sbose78
Copy link
Contributor

@sbose78 sbose78 commented Mar 22, 2021

Signed-off-by: Shoubhik Bose [email protected]

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sbose78
Copy link
Contributor Author

sbose78 commented Mar 22, 2021

partially takes care of #218

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #248 (1b5af32) into master (380f7be) will decrease coverage by 1.02%.
The diff coverage is 14.81%.

❗ Current head 1b5af32 differs from pull request most recent head 767a9be. Consider uploading reports for the commit 767a9be to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   50.90%   49.87%   -1.03%     
==========================================
  Files          40       40              
  Lines        3096     3186      +90     
==========================================
+ Hits         1576     1589      +13     
- Misses       1361     1437      +76     
- Partials      159      160       +1     
Impacted Files Coverage Δ
pkg/sync/common/types.go 58.82% <ø> (ø)
pkg/utils/kube/ctl.go 2.24% <0.00%> (-0.58%) ⬇️
pkg/sync/sync_context.go 71.97% <70.00%> (+0.03%) ⬆️
pkg/health/health_hpa.go 82.66% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380f7be...767a9be. Read the comment docs.

@alexmt alexmt merged commit c1332ab into argoproj:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants