build: upgrade kit
#14105
Merged
build: upgrade kit
#14105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonM
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Thanks @alexec! I entered kitproj/kit#81 because kit ui-deps is currently broken, and it looks like you solved that here.
| kubectl -n argo port-forward "svc/$resource" "$port:$dest_port" & | ||
| until lsof -i ":$port" > /dev/null ; do sleep 1 ; done | ||
| } | ||
| go install github.com/kitproj/[email protected] |
There was a problem hiding this comment.
Nice! I made my own attempt at getting rid of kubectl port-forward a little while ago: main...MasonM:argo-workflows:no-port-forward
The idea is to change all services to be of type LoadBalancer. With k3s, that means ServiceLB will automatically forward the port to the host. This works, but it kinda couples the dev environment to k3s, since some distributions (e.g. kind) don't come with a LoadBalancer out-of-the-box. It looks like kubeauto doesn't have that problem.
alexec
commented
Jan 27, 2025
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Co-authored-by: Mason Malone <[email protected]> Signed-off-by: Alex Collins <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: oninowang <[email protected]> Signed-off-by: Alex Collins <[email protected]>
#14102 (#14104) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Kaan C. Fidan <[email protected]> Signed-off-by: Alex Collins <[email protected]>
…nAsNonRoot (#14072) Signed-off-by: Paul Watts <[email protected]> Co-authored-by: Mason Malone <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: MenD32 <[email protected]> Co-authored-by: MenD32 <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
|
Good to see you, Alex :-) |
terrytangyuan
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N/A
Motivation
Improve the user experience by updating to the latest version.
Modifications
Updated tasks.yaml and other build files.
Verification