feat(argo-cd): support Argo cd core installation#3434
feat(argo-cd): support Argo cd core installation#3434remyj38 wants to merge 1 commit intoargoproj:mainfrom
Conversation
remyj38
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
remyj38
force-pushed
the
feat/core
branch
2 times, most recently
from
d72b742 to
f5c0ffe
Compare
|
|
||
| ```yaml | ||
| server: | ||
| enabled: false |
There was a problem hiding this comment.
given one can already set https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/values.yaml#L1928 this to "0". What is this PR achieving?
This isn't how i'd have expected core mode to have been enabled.
There was a problem hiding this comment.
Setting server to zero replicas will only disable the deployment, but all resources linked to it will be created (RBAC, ...)
So, IMHO, it's cleaner to add an option to completely disable the server, to prevent creation of unnecessary resources.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
remyj38
force-pushed
the
feat/core
branch
2 times, most recently
from
c5264c3 to
3fc78e9
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This PR is not stale, only waiting for approval |
Close argoproj#1823 Signed-off-by: Rémy Jacquin <remy@remyj.fr>
|
I suggest you change your PR title to be something like "support Argo cd core installation". Your current PR title is misleading imo. |
remyj38
changed the title
2 participants
Allow to disable server to use Argo-CD core mode (server and dex disabled)
Close #1823
Checklist: