Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make BeforeHookCreation resources progressing until recreated, fixes #10077 #10579

Conversation

nazarewk
Copy link
Contributor

fixes #10077

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates? No
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

…ing until recreated

fixes argoproj#10077

Signed-off-by: Krzysztof Nazarewski <[email protected]>
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #10579 (26f19e8) into master (9fac0f6) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master   #10579      +/-   ##
==========================================
- Coverage   45.69%   45.69%   -0.01%     
==========================================
  Files         234      234              
  Lines       28508    28520      +12     
==========================================
+ Hits        13027    13032       +5     
- Misses      13694    13697       +3     
- Partials     1787     1791       +4     
Impacted Files Coverage Δ
controller/health.go 80.85% <53.84%> (-13.44%) ⬇️
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nazarewk
Copy link
Contributor Author

nazarewk commented Sep 13, 2022

I'm not 100% sure I'm doing it in right place
everything else is in gitops-engine and it doesn't seem to know operation's start date it does know start date

nazarewk added a commit to surgeventures/gitops-engine that referenced this pull request Sep 13, 2022
@nazarewk
Copy link
Contributor Author

this is lost likely a better idea argoproj/gitops-engine#461

@nazarewk nazarewk closed this Sep 13, 2022
nazarewk added a commit to surgeventures/gitops-engine that referenced this pull request Sep 13, 2022
- fixes argoproj#446
- closes argoproj/argo-cd#10579
- original issue argoproj/argo-cd#10077

Signed-off-by: Krzysztof Nazarewski <[email protected]>
nazarewk added a commit to surgeventures/gitops-engine that referenced this pull request Sep 13, 2022
- fixes argoproj#446
- closes argoproj/argo-cd#10579
- original issue argoproj/argo-cd#10077

Signed-off-by: Krzysztof Nazarewski <[email protected]>
nazarewk added a commit to surgeventures/gitops-engine that referenced this pull request Sep 14, 2022
- fixes argoproj#446
- closes argoproj/argo-cd#10579
- original issue argoproj/argo-cd#10077

Signed-off-by: Krzysztof Nazarewski <[email protected]>
thober35 pushed a commit to thober35/gitops-engine that referenced this pull request Oct 25, 2023
- fixes argoproj#446
- closes argoproj/argo-cd#10579
- original issue argoproj/argo-cd#10077

Signed-off-by: Krzysztof Nazarewski <[email protected]>
thober35 pushed a commit to thober35/gitops-engine that referenced this pull request Oct 26, 2023
thober35 added a commit to thober35/argo-cd that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo CD considers PreSync phase finished even though the Job was just created
1 participant