Skip to content

Commit

Permalink
fix: Documentation add ARGOCD_ENV_ prefix to AVP_SECRET variable
Browse files Browse the repository at this point in the history
  • Loading branch information
IvanVojtko committed Jul 3, 2024
1 parent 810f1fe commit d8bd730
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ data:
- name: aws-avp
generate:
command: ["sh", "-c"]
args: ["argocd-vault-plugin generate -s ${AVP_SECRET} ./"]
args: ["argocd-vault-plugin generate -s ${ARGOCD_ENV_AVP_SECRET} ./"]
```

Notice that the secret name is parametrized via an environment variable. This means each Argo app manifest can set `AVP_SECRET` to be the name of the Kubernetes secret that contains the configuration for the backend needed to generate its secrets.
Expand Down Expand Up @@ -238,4 +238,4 @@ spec:
value: foo-team-namespace
```

**Note**: Exposing tokens (like `AVP_ROLE_ID` or `AVP_SECRET_ID`) in plain-text in Argo CD app manifests should be avoided. Prefer to pass those tokens through one of the means mentioned above.
**Note**: Exposing tokens (like `AVP_ROLE_ID` or `AVP_SECRET_ID`) in plain-text in Argo CD app manifests should be avoided. Prefer to pass those tokens through one of the means mentioned above.

0 comments on commit d8bd730

Please sign in to comment.