Skip to content

Conversation

@dkarpele
Copy link
Collaborator

@dkarpele dkarpele commented Dec 15, 2025

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to the latest compatible versions for improved stability and compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

…scanner from v1.0.0 to v1.0.2

Signed-off-by: dkarpele <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Walkthrough

Updated the registry-scanner dependency version from v1.0.0 to v1.0.2 in the Go module file. The change updates a single external dependency without altering control flow or error handling logic.

Changes

Cohort / File(s) Summary
Go module dependencies
go.mod
Updated github.com/argoproj-labs/argocd-image-updater/registry-scanner from v1.0.0 to v1.0.2

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: updating a specific dependency version in go.mod from v1.0.0 to v1.0.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb6562c and 5dcca47.

📒 Files selected for processing (1)
  • go.mod (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-30T17:35:33.906Z
Learnt from: dkarpele
Repo: argoproj-labs/argocd-image-updater PR: 1377
File: docs/install/installation.md:14-20
Timestamp: 2025-11-30T17:35:33.906Z
Learning: In argocd-image-updater v1.x+, the Kustomize base is located at `/config/default` in the repository, not `/manifests/base` (which was the legacy location in v0.x versions). The correct remote base URL is `https://github.com/argoproj-labs/argocd-image-updater/config/default`.

Applied to files:

  • go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Ensure code is correctly linted
  • GitHub Check: Ensure registry-scanner Go modules synchronicity and run tests
  • GitHub Check: Run end-to-end tests (v1.27.1)
  • GitHub Check: Ensure unit tests are passing
  • GitHub Check: Analyze (go)
  • GitHub Check: build_image
🔇 Additional comments (2)
go.mod (2)

201-203: Clarify the intent of the active replace directive.

The replace directive at lines 201–203 points to a local path and overrides the version specified in line 6. The comment notes this should be "commented out for releases." Confirm whether this should be commented out for this PR, as leaving it active means the v1.0.2 version bump will not be used during builds.


6-6: The version v1.0.2 does not appear to have a public release, and the replace directive will override this change until commented out.

The registry-scanner replace directive on line 203 is currently active (github.com/argoproj-labs/argocd-image-updater/registry-scanner => ./registry-scanner/), which will override the version specified on line 6. This change will only take effect for releases when that replace is commented out. More critically, v1.0.2 does not appear to have a public release on the GitHub releases page—only v1.0.0 and v1.0.1 are documented. Verify that v1.0.2 exists or correct to the intended version (likely v1.0.1).

⛔ Skipped due to learnings
Learnt from: dkarpele
Repo: argoproj-labs/argocd-image-updater PR: 1377
File: docs/install/installation.md:14-20
Timestamp: 2025-11-30T17:35:33.906Z
Learning: In argocd-image-updater v1.x+, the Kustomize base is located at `/config/default` in the repository, not `/manifests/base` (which was the legacy location in v0.x versions). The correct remote base URL is `https://github.com/argoproj-labs/argocd-image-updater/config/default`.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.81%. Comparing base (fb6562c) to head (5dcca47).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1397   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files          49       49           
  Lines        4540     4540           
=======================================
  Hits         3215     3215           
  Misses       1130     1130           
  Partials      195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarpele dkarpele merged commit 5a86f49 into argoproj-labs:master Dec 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants