Set watchOS and visionOS minimum deployment targets in Package manifest instead #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes redundant @available(macOS 13, iOS 16, watchOS 10, visionOS 1, *) availability annotations from the WhisperKit codebase since the minimum deployment targets are already set in Package.swift to macOS 13 and iOS 16.
- Removes over 40 redundant availability checks from classes, structs, protocols, functions, and extensions
- Affects test files, CLI components, and core library code
- Maintains existing availability checks only for deprecated functions which still have meaningful availability restrictions
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/WhisperKitTests/UnitTests.swift | Removes availability check from test class |
| Tests/WhisperKitTests/TestUtils.swift | Removes availability checks from utility extensions |
| Tests/WhisperKitTests/RegressionTests.swift | Removes availability check from regression test class |
| Tests/WhisperKitTests/RegressionTestUtils.swift | Removes availability checks from test utility classes |
| Tests/WhisperKitTests/FunctionalTests.swift | Removes availability check from functional test class |
| Sources/WhisperKitCLI/*.swift | Removes availability checks from CLI command structures |
| Sources/WhisperKit/Utilities/*.swift | Removes availability checks from utility functions and extensions |
| Sources/WhisperKit/Core/*.swift | Removes availability checks from core library classes and protocols |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
naykutguven
force-pushed
the
remove-redundant-os-availability-checks
branch
from
2279447 to
03a1aee
Compare
naykutguven
changed the title
naykutguven
force-pushed
the
remove-redundant-os-availability-checks
branch
from
03a1aee to
341279b
Compare
naykutguven
force-pushed
the
remove-redundant-os-availability-checks
branch
from
341279b to
f3773ea
Compare
|
Hey @ZachNagengast wdyt about this one? |
ZachNagengast
approved these changes
Oct 3, 2025
awesome, thank you! ready when you are 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
@available(macOS 13, iOS 16, watchOS 10, visionOS 1, *)availability annotations across the codebase since the minimum deployment targets are already set as macOS 13 and iOS 16 inPackage.swift.