Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor naming columns steps combinecolumns combinekeys expandcolumns #758

Conversation

davidberenstein1957
Copy link
Member

@davidberenstein1957 davidberenstein1957 commented Jun 26, 2024

Closes #755

Copy link

codspeed-hq bot commented Jun 26, 2024

CodSpeed Performance Report

Merging #758 will not alter performance

Comparing feat/755-feature-review-naming-columns-steps-combinecolumns-combinekeys-expandcolumns (6f9948c) with feat/755-feature-review-naming-columns-steps-combinecolumns-combinekeys-expandcolumns (1283372)

Summary

✅ 1 untouched benchmarks

@davidberenstein1957 davidberenstein1957 added this to the 1.3.0 milestone Jun 26, 2024
@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review June 26, 2024 13:34
@davidberenstein1957 davidberenstein1957 self-assigned this Jun 26, 2024
Copy link
Member

@gabrielmbmb gabrielmbmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/distilabel/pipeline/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@davidberenstein1957 davidberenstein1957 merged commit 5fb28b6 into develop Jun 26, 2024
6 checks passed
@davidberenstein1957 davidberenstein1957 deleted the feat/755-feature-review-naming-columns-steps-combinecolumns-combinekeys-expandcolumns branch June 26, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants