Add fast-reboot check for warm-restart common-helper #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazariig
reviewed
Jun 6, 2023
| auto& warmStart = getInstance(); | ||
|
|
||
| // Check system level warm-restart config first | ||
| warmStart.m_stateFastRestartEnableTable->hget("system", "enable", value); |
There was a problem hiding this comment.
@arfeigin what is the behaviour when record is not present in DB? Will it throw an exception?
There was a problem hiding this comment.
According to table.cpp implementation it will return false in not present. It might throw an exception if entry exists but value is not a string. I used the same logic used for checkWarmStart.
sonic-swss-common/common/table.cpp
Line 98 in f02a35a
nazariig
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to check if fast-reboot is in progress, similar to warm-reboot.
This is needed to differ fast-reboot from warm-reboot as fast-reboot is using warm-reboot infrastructure.