Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete doc files for removed crosswind dissipation source code #261

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

smpark7
Copy link
Collaborator

@smpark7 smpark7 commented Mar 1, 2024

The gh-pages action for the documentation failed to build because I accidentally included two unwanted doc files in #248.

While working on #248, I removed the source code for crosswind dissipation capability to save it for a later PR. But I forgot to delete doc files associated with them. I didn't notice the error because I built the preview documentation website prior to the source code removal.

I created issue #260 for setting up a CI test to ensure that documentation builds correctly following a PR.

@samgdotson
Copy link
Contributor

samgdotson commented Mar 1, 2024

@smpark7 can you add an additional check to the repository that builds the github-pages docs?

Edit:
Okay, #260 addresses this -- egg on my face for not reading the PR fully 😆

@smpark7
Copy link
Collaborator Author

smpark7 commented Mar 1, 2024

Do you mean a CI test like what I described in #260?

@samgdotson
Copy link
Contributor

samgdotson commented Mar 1, 2024

Do you mean a CI test like what I described in #260?

Yes, lol -- are you actively working on this?

@samgdotson samgdotson closed this Mar 1, 2024
@samgdotson samgdotson reopened this Mar 1, 2024
@smpark7
Copy link
Collaborator Author

smpark7 commented Mar 1, 2024

Not at the moment. Maybe in the next 1-2 weeks

Copy link
Contributor

@samgdotson samgdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@samgdotson samgdotson merged commit cd016cd into arfc:devel Mar 2, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 2, 2024
Delete doc files for removed crosswind dissipation source code cd016cd
github-actions bot pushed a commit to smpark7/moltres that referenced this pull request Mar 19, 2024
Delete doc files for removed crosswind dissipation source code cd016cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants