-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete doc files for removed crosswind dissipation source code #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you mean a CI test like what I described in #260? |
Yes, lol -- are you actively working on this? |
Not at the moment. Maybe in the next 1-2 weeks |
samgdotson
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
github-actions bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
Delete doc files for removed crosswind dissipation source code cd016cd
github-actions bot
pushed a commit
to smpark7/moltres
that referenced
this pull request
Mar 19, 2024
Delete doc files for removed crosswind dissipation source code cd016cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gh-pages action for the documentation failed to build because I accidentally included two unwanted doc files in #248.
While working on #248, I removed the source code for crosswind dissipation capability to save it for a later PR. But I forgot to delete doc files associated with them. I didn't notice the error because I built the preview documentation website prior to the source code removal.
I created issue #260 for setting up a CI test to ensure that documentation builds correctly following a PR.