Add neutron leakage postprocessors and allow for optional group constants #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smpark7
changed the title
smpark7
force-pushed
the
leakage-postprocessor
branch
from
6504d5c
to
48447d0
Compare
smpark7
force-pushed
the
leakage-postprocessor
branch
from
48447d0
to
17819e3
Compare
smpark7
requested review from
abachma2,
ZoeRichter,
LukeSeifert,
samgdotson,
yardasol and
nsryan2
LukeSeifert
previously approved these changes
Dec 12, 2023
|
Thanks @LukeSeifert! This is ready for another review. Feel free to merge if you approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234 and #167
Users can now choose which group constants they're providing to Moltres through the
group_constantsinput parameter forMoltresJsonMaterial. This is useful for many problems which do not require every group constant type (e.g. eigenvalue problems do not require inverse neutron velocity data, neutronics-only problems do not require average fission energy released).