-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARFC Moltres website migration #231
Conversation
e81dbd3
to
9b1816d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smpark7. Great work on this, it looks really good overall. I had a few very small suggestions that are optional. I saw that one of the CI tests fails and I didn't really dig into why. I know you have a few PRs right now, so I'm guessing one of those PRs fixes it all. Let me know when this is ready to merge.
Thanks for your review @abachma2. The CI is failing at the "initialize test environment" phase and I don't know why. This PR sets up new tests but it doesn't touch any source code. I'll ping you when it's been sorted. |
The tests are running properly now. I just added an input mesh for the tutorial which I initially missed because of gitignore. This PR is ready for review and merge (unless you have new comments). @abachma2 |
@abachma2 pinging you for a review and merge |
Thanks for the reminder! Merging now. |
Thanks Amanda! |
ARFC Moltres website migration 2cb1480
ARFC Moltres website migration 2cb1480
Fixes #179
Description
This PR migrates existing content on the ARFC Moltres website (https://arfc.github.io/software/moltres/) to the newer MooseDocs-based website (https://arfc.github.io/moltres/). A preview with the changes in this PR is available on my personal github website (https://smpark7.github.io/moltres/index.html).
Changes
Impact