-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR and Issue templates #178
Conversation
(Meta question) Do we want the templates to be strictly followed or to be general guidelines? I recognize the benefits of standardization since we welcome outside contributors, but I find the headers in the issue templates to be quite restrictive. I would prefer to have the As for the PR template, I think the checklist is good for reminding contributors (and ourselves) of our expectations. |
@smpark7 great suggestions. Could you go ahead and suggest those changes so you can get commit credit for them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good addition. I have no problem with them as written. I see @smpark7 has made a suggestion and @yardasol has suggested that @smpark7 implement those suggested changes. For expediency, I recommend either the original PR author @yardasol incorporate those recommendations OR merging as is and allowing @smpark7 to make a separate PR with those changes sometime later.
I'm okay with merging as is and refining the template later. |
Thank you. Merged. |
This PR adds PR and Issue templates to the repo. They are similar to the ones i made for SaltProc but with some better formatting.
closes #130