Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Doxygen/Github Pages action trigger on pull requests #171

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

smpark7
Copy link
Collaborator

@smpark7 smpark7 commented Oct 11, 2021

The current Doxygen/Github Pages action, which updates gh-pages, triggers on both merges and pull request creations into devel. We only need gh-pages to be updated when changes are merged into devel, i.e. after PRs are approved.

This PR makes the Doxygen/Github Pages action trigger only when commits are pushed into devel, and not when PRs are created.

@smpark7 smpark7 requested a review from munkm October 11, 2021 23:32
@smpark7 smpark7 self-assigned this Oct 11, 2021
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we keep an action on pull requests to make sure that the files can be built, but we don't deploy them on PR? That way if an error is introduced in a PR we can fix it, but the docs deployment only happens once the merge happens?

@smpark7
Copy link
Collaborator Author

smpark7 commented Oct 18, 2021

As we've discussed during our meeting, I agree that we should have a check on PRs to ensure files can be built. I've created issue #176 to introduce that feature. Can we merge this change first?

Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@munkm munkm merged commit c3ee875 into arfc:devel Oct 18, 2021
@smpark7
Copy link
Collaborator Author

smpark7 commented Oct 18, 2021

Thank you!

@smpark7 smpark7 deleted the disable-action-on-pr branch October 18, 2021 20:02
github-actions bot pushed a commit that referenced this pull request Oct 18, 2021
Disable Doxygen/Github Pages action trigger on pull requests c3ee875
github-actions bot pushed a commit to yardasol/moltres that referenced this pull request Oct 25, 2021
Disable Doxygen/Github Pages action trigger on pull requests c3ee875
github-actions bot pushed a commit to gwenchee/moltres that referenced this pull request Oct 29, 2021
Disable Doxygen/Github Pages action trigger on pull requests c3ee875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants